Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Gatsby Admin build step to postbuild of Gatsby itself #25908

Closed
mxstbr opened this issue Jul 21, 2020 · 0 comments · Fixed by #25940
Closed

Move Gatsby Admin build step to postbuild of Gatsby itself #25908

mxstbr opened this issue Jul 21, 2020 · 0 comments · Fixed by #25940
Assignees
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@mxstbr
Copy link
Contributor

mxstbr commented Jul 21, 2020

Currently we have some issues with how Gatsby Admin is deployed. It's being build in pre-publish and this can cause weird behaviour eg when testing changes. Thus Gatsby Admin should be built/deployed differently.
I think however, we should keep the setup where we publish compiled artifacts. I do think that there is no reason to have separate package for that, instead admin artifacts should be included in Gatsby package itself.

Move to post-build of Gatsby
[...] that means we make this command be a post-build command for gatsby. That command should use currently compiled version of Gatsby.

@mxstbr mxstbr added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change topic: admin labels Jul 21, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 21, 2020
@mxstbr mxstbr removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 21, 2020
@mxstbr mxstbr self-assigned this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant