perf(gatsby-source-contentful): fix API, execute deprecations, improve performance #27244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
axe312ger
added
status: needs core review
4 tasks
pvdz
removed
the
status: needs core review
This was referenced Oct 2, 2020
…es (gatsbyjs#23514) * fix(gatsby-source-contentful): fixed id collision in contentful entries
…es (gatsbyjs#23514) * fix(gatsby-source-contentful): fixed id collision in contentful entries
* improve comment about contentful-resolve-response usage * test(unit): remove cross test data pollution * further improve loggin by replacing console.time with GatsbyReporter * improve code style * missing file * remove logging verbosity * adjust mocked reporter for tests to pass * remove unused deep-map dependency
… and latest sync API response
axe312ger
force-pushed
the
contentful-next-pre-rich-text
branch
from
794cc1e
to
958ba8a
Compare
pvdz
approved these changes
Oct 5, 2020
| @@ -189,37 +263,61 @@ exports.sourceNodes = async ( | |||
| useNameForId: pluginConfig.get(`useNameForId`), | |||
| }) | |||
|
|
|||
| reporter.verbose(`Resolving Contentful references`) | |||
|
|
|||
| const newOrUpdatedEntries = [] | |||
There was a problem hiding this comment.
This ought to be a Set but we can fix that in a followup PR.
Comment on lines
+426
to
+430
| return mId( | ||
| space.sys.id, | ||
| v.sys.id, | ||
| v.sys.linkType || v.sys.type | ||
| ) |
There was a problem hiding this comment.
This sort of thing happens a lot. I think some can be abstracted a little better (but not all).
pvdz
changed the title
|
(Merged per agreement with @axe312ger) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts all non Rich Text related fixes from #25249