chore(gatsby-plugin-flow): Add pluginOptionsSchema validation #27599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
|
Thanks! Can you add tests? |
|
please add them cause when we add options we should update the tests, even if it's an empty object. |
ascorbic
added
topic: plugins
MichaelDeBoey
force-pushed
the
plugin-flow/add-pluginOptionsSchema-validation
branch
2 times, most recently
from
9899009
to
7936fe0
Compare
|
👋 @MichaelDeBoey thank you so much for tackling this, love it! 💯 I'm working on the last bits and pieces for plugin option validation to be stable right now, after which I'm going to take a look at shipping these PRs 👍 #27600 #27601 #27602 |
|
@mxstbr Take your time, there's no rush 😉 |
MichaelDeBoey
force-pushed
the
plugin-flow/add-pluginOptionsSchema-validation
branch
from
7936fe0
to
4adddc8
Compare
mxstbr
previously approved these changes
Nov 4, 2020
mxstbr
added
the
bot: merge on green
MichaelDeBoey
force-pushed
the
plugin-flow/add-pluginOptionsSchema-validation
branch
from
680d743
to
1531e15
Compare
MichaelDeBoey
force-pushed
the
plugin-flow/add-pluginOptionsSchema-validation
branch
from
e0037b3
to
8aa6c22
Compare
…luginOptionsSchema-validation
MichaelDeBoey
deleted the
plugin-flow/add-pluginOptionsSchema-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just like @mxstbr did in #27356