Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-source-contentful] Missing support for transforming image assets with cornerRadius #29784

Closed
bobeagan opened this issue Feb 25, 2021 · 8 comments · Fixed by #32333
Closed
Labels
topic: source-contentful Related to Gatsby's integration with Contentful type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.

Comments

@bobeagan
Copy link

Description

Attempting to run a GraphQL query for an Asset from Contentful does not allow specifying a cornerRadius option. All other options appear to be present except that one.

Steps to reproduce

Attempt to build a query that tries to transform the image using cornerRadius and see that it is not supported or inspect the schema for the type (see below)
image

Expected result

It should support all of the options according to the Contentful spec

Actual result

Receive error in GraphiQL explorer: `Unknown argument "cornerRadius" on field "fixed" of type "ContentfulAsset".

Environment

Can see that it is not present in the current master branch:

const fixedNodeType = ({ name, getTracedSVG }) => {

@bobeagan bobeagan added the type: bug An issue or pull request relating to a bug in Gatsby label Feb 25, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 25, 2021
@vladar vladar added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 26, 2021
@vladar
Copy link
Contributor

vladar commented Feb 26, 2021

CC @axe312ger

@axe312ger axe312ger modified the milestone: Next Major Mar 8, 2021
@axe312ger axe312ger added this to To do in Contentful source plugin improvements via automation Mar 8, 2021
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Mar 28, 2021
@bobeagan
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Mar 29, 2021
@axe312ger
Copy link
Collaborator

@bobeagan Any reason why you don't do this with CSS?

@bobeagan
Copy link
Author

I'm already transforming the image and its available via their API so seems nice to be able to have it handled and cached on their end. As a workaround we are doing with CSS for now though. I just felt it would be nice to have full coverage of their image API capabilities available.

@axe312ger axe312ger added type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed type: bug An issue or pull request relating to a bug in Gatsby labels Mar 30, 2021
@axe312ger
Copy link
Collaborator

Will leave this open as feature request. Feel free to create a PR, I am happy to review an merge.

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jun 7, 2021
@axe312ger axe312ger added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Jun 7, 2021
@axe312ger
Copy link
Collaborator

This is not forgotten, and as other issues with higher priority getting done, I might find time to add this in the follow weeks :)

@axe312ger axe312ger moved this from To do to In progress in Contentful source plugin improvements Jul 12, 2021
Contentful source plugin improvements automation moved this from In progress to Done Jul 15, 2021
wardpeet pushed a commit that referenced this issue Jul 15, 2021
closes #29784

Co-authored-by: axe312ger <opensource@axe312.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Development

Successfully merging a pull request may close this issue.

4 participants