Refactor memory leak by setInterval code gatsby dev-ssr

[simonjoom]

Preliminary Checks

• This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/gatsbyjs/gatsby/issues
• This issue is not a question, feature request, RFC, or anything other than a bug report directly related to Gatsby. Please post those things in GitHub Discussions: https://github.com/gatsbyjs/gatsby/discussions

Description

The code give me a problem to get a good result in the compilation of dev-ssr

Reproduction Link

https://github.com/noreproductionlinkprovided

Steps to Reproduce

1. Need a big project with long webpack compilation to reproduce

...

Expected Result

Compilation ssr should to pass correctly

Actual Result

memory leak due to setInterval and too much pass attempt
In actual code setInterval can run again before the stream finish for a big render-page

Environment

Mac os
Last gatsby4

Config Flags

DEV_SSR:true

code problem:

gatsby/packages/gatsby/src/utils/dev-ssr/render-dev-html.ts

Lines 113 to 136 in a629551

	let found = await searchFileForString(
	page.componentChunkName,
	htmlComponentRendererPath
	)
	if (!found) {
	await new Promise<void>(resolve => {
	let readAttempts = 0
	const searchForStringInterval = setInterval(async () => {
	readAttempts += 1
	found = await searchFileForString(
	page.componentChunkName,
	htmlComponentRendererPath
	)
	if (found || (allowTimedFallback && readAttempts > 5)) {
	clearInterval(searchForStringInterval)
	resolve()
	}
	}, 300)
	})
	}
	return found
	}

My Resolution

increment readAttempts and remove setInterval

let found = await searchFileForString(page.componentChunkName, htmlComponentRendererPath);

  if (!found) { 
    const delay = (ms) => { new Promise(resolve => setTimeout(resolve, ms)) }
    const lookforit = async (readAttempts) => { 
      found = await searchFileForString(page.componentChunkName, htmlComponentRendererPath);
      if (found || allowTimedFallback && readAttempts > 50) {
        console.log("isfound", found)
        return found; 
      } else {
        console.log("notfound", found)
        await delay(300);
        return await lookforit(readAttempts+1)
      }
    } 

    const bool = await lookforit(0)
    return bool
}

[tyhopp]

Hi @simonjoom,

Sorry to hear you're running into an issue. To help us best begin debugging the underlying cause, it is incredibly helpful if you're able to create a minimal reproduction. This is a simplified example of the issue that makes it clear and obvious what the issue is and how we can begin to debug it.

Thanks for using Gatsby! 💜

[LekoArts]

Hi!

Since we didn't receive an answer for 7 days or more about the ask of a reproduction I'm going to close this now, as we can't do much to help without a reproduction. If you are able to create a minimal reproduction for this then please do answer here or open a new issue with a reproduction. Thanks!