New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of query-runner error log #5379

Closed
m-allanson opened this Issue May 11, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@m-allanson
Copy link
Member

m-allanson commented May 11, 2018

Summary

PR #5214 added extra context to the query-runner error log.

There was some discussion on whether the formatting could be neater. Look into this suggestion or find some other way of improving the error format.

Motivation

Tidier error messages are easier to read.

@alexluong

This comment has been minimized.

Copy link
Contributor

alexluong commented May 24, 2018

Hi, I went ahead and tried to help with this. How does this look?

screen shot 2018-05-24 at 4 55 53 am

@flipactual

This comment has been minimized.

Copy link
Member

flipactual commented May 25, 2018

Closing per 12c20f8 !

Please re-open the issue if there's more to be done 💃

@flipactual flipactual closed this May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment