Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting of query-runner error log #5379

Closed
m-allanson opened this issue May 11, 2018 · 2 comments
Closed

Improve formatting of query-runner error log #5379

m-allanson opened this issue May 11, 2018 · 2 comments
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@m-allanson
Copy link
Contributor

Summary

PR #5214 added extra context to the query-runner error log.

There was some discussion on whether the formatting could be neater. Look into this suggestion or find some other way of improving the error format.

Motivation

Tidier error messages are easier to read.
@m-allanson m-allanson added help wanted Issue with a clear description that the community can help with. good first issue Issue that doesn't require previous experience with Gatsby type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change labels May 11, 2018
@alexluong
Copy link
Contributor

Hi, I went ahead and tried to help with this. How does this look?

screen shot 2018-05-24 at 4 55 53 am

@alexluong alexluong mentioned this issue May 24, 2018
Merged
@flipactual
Copy link
Contributor

Closing per 12c20f8 !

Please re-open the issue if there's more to be done 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m-allanson @flipactual @alexluong