Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
When a Gatsby website loads, the user can happily start scrolling. However, after some time has elapsed the page scrolls back up to the top.
This can be reproduced at https://www.gatsbyjs.org/ or https://reactjs.org/ by going to the website with a throttled network connection and scrolling down before render() is called.
It should not scroll to the top
It scrolls to the top. This will not happen if JS is disabled.
The text was updated successfully, but these errors were encountered:
Thanks for the report @developerdavo. This is mentioned over in #5675. For anyone interested in picking this up, check the discussion in 5675 for pointers on where to start investigating.
Sorry, something went wrong.
Any update on this? I don't believe it's resolved in v2.
@humphreybc no not yet unfortunately. The fix is I believe to check in https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-react-router-scroll/README.md if scroll has already happened and to not then scroll to the top which is it's default. Or perhaps easier to just not scroll at all on the initial load of the website.
Would you like to work on a PR? This would be really nice to fix!
@KyleAMathews I would love to but I'm a bit short on time right now unfortunately 🙁
No worries :-) hopefully someone will pick this up soon
I think this would be fixed by returning false in shouldUpdateScroll. The problem is: what should happen on page reload (when we want to scroll to the last saved position)?
This is probably the same thing that is happening for me whenever I am actively scrolling the page and a part of the DOM changes with a timer. I'll try to post a simple repro.
This issue has gone quiet. Spooky quiet. 👻
We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
Thanks for being a part of the Gatsby community! 💪💜
I really think that this one is important
@wardpeet actually fixed this a couple of weeks ago!
Successfully merging a pull request may close this issue.