Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perilbot] validate updates to the site showcase #6538

Closed
m-allanson opened this issue Jul 18, 2018 · 3 comments
Closed

[perilbot] validate updates to the site showcase #6538

m-allanson opened this issue Jul 18, 2018 · 3 comments

Comments

@m-allanson
Copy link
Contributor

m-allanson commented Jul 18, 2018

Summary

Use Gatsby's Peril setup to automatically check any pull request that modifies the list of showcase sites.

It should verify that added sites contain the correct fields - url, categories etc.

Basic example

Example message notifiying about missing fields:

Gadzooks! It looks like you forgot to add a link to your new site. You should update your pull request to include a url field that links to your site.

Stretch goals:

  • check categories and suggest related categories, highlight possible typos or alert to categories where your site will be the only site in the category?
  • check that urls are valid

Motivation

Missing fields mean the added site may not get published to the showcase.

@jlengstorf
Copy link
Contributor

Gadzooks!

😂

I love this idea. I'm going to set up a project proposal to track ideas like these, and we'll see if we can get it prioritized.

@jlengstorf jlengstorf changed the title Use Peril to validate updates to the site showcase [perilbot] validate updates to the site showcase Jul 30, 2018
@m-allanson
Copy link
Contributor Author

Additional things Peril could do:

  • automatically add a date_added field
  • automatically add a gatsby_version field

(ref: #6930)

@jlengstorf
Copy link
Contributor

@pieh Is this the one you wanted to tackle?

Gatsby Repo Workflows automation moved this from To do to Done Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants