Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perilbot] validate yaml for different yaml files + required fields #6634

Closed
KyleAMathews opened this issue Jul 20, 2018 · 6 comments
Closed
Assignees
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change

Comments

@KyleAMathews
Copy link
Contributor

E.g. the site showcase yaml file.

Travis does this but it'd be nicer to put up a comment with the YAML error printed out so it's easier for people to fix. Many people never look at Travis.

@KyleAMathews
Copy link
Contributor Author

@calcsam just had a great idea too that Peril could auto-merge site show case PRs. It'd validate that it's a Gatsby site, make sure it isn't a porn site, and then merge it in.

@jlengstorf
Copy link
Contributor

@KyleAMathews @calcsam I can definitely look into this. I have no idea if there's a way to reliably validate that it's not porn, though.

@KyleAMathews
Copy link
Contributor Author

Yeah, it doesn't have to be perfect — or do any checking really at first — we can just manually check them after the fact and revert any that we don't want in the showcase.

@KyleAMathews
Copy link
Contributor Author

I think just checking they're linking to a Gatsby site would be sufficient to start with — which is trivial as grab HTML from site and look for ___gatsby

@KyleAMathews
Copy link
Contributor Author

The bot could also post a screenshot to the comment section which would further speed up reviewing sites.

@m-allanson m-allanson added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Jul 24, 2018
@m-allanson m-allanson added this to To do in Gatsby Repo Workflows via automation Jul 24, 2018
@fk
Copy link
Contributor

fk commented Jul 24, 2018

Ref. #6538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
No open projects
Development

No branches or pull requests

4 participants