Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starter library - set filter default to Gatsby v2 #7900

Closed
shannonbux opened this issue Sep 5, 2018 · 1 comment
Closed

starter library - set filter default to Gatsby v2 #7900

shannonbux opened this issue Sep 5, 2018 · 1 comment
Assignees
@chmac

Comments

@shannonbux
Copy link
Contributor

shannonbux commented Sep 5, 2018 •
edited

@LekoArts in issue #7785

I commented somewhere else that I'd propose to use a filter for v1 and v2 on the sidebar and set v2 by default. This way people could upgrade by themselves and the creators have some time to upgrade. After some time the v1 starters would be removed + the filter option.
@gatsbot

This comment has been minimized.

Sign in to view
@shannonbux shannonbux mentioned this issue Sep 5, 2018
Closed
@LekoArts LekoArts mentioned this issue Oct 19, 2018
Closed
chmac added a commit to GatsbyCentral/gatsby that referenced this issue Oct 19, 2018
@chmac
Filter for v2 starters by default. gatsbyjs#7900
a91bd80
@chmac chmac mentioned this issue Oct 19, 2018
Closed
@chmac chmac self-assigned this Oct 19, 2018
@amberleyromo amberleyromo changed the title starter showcase - set filter default to Gatsby v2 starter library - set filter default to Gatsby v2 Oct 24, 2018
@amberleyromo amberleyromo mentioned this issue Nov 6, 2018
Merged
amberleyromo added a commit that referenced this issue Nov 9, 2018
@amberleyromo
feat(starters): Filter v2 by default (#9739)
4064e35 
* Filter for v2 starters by default. #7900

* WIP

* fix reset all filters issue

* move out default search option

* wip

* refactor to use render prop

* fix filtersApplied for metadata

* pr refactor

* linting
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019
@amberleyromo @gpetrioli
feat(starters): Filter v2 by default (gatsbyjs#9739)
8dc71fb 
* Filter for v2 starters by default. gatsbyjs#7900

* WIP

* fix reset all filters issue

* move out default search option

* wip

* refactor to use render prop

* fix filtersApplied for metadata

* pr refactor

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chmac chmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[starter library] WIP Filter for v2 starters by default GatsbyCentral/gatsby
4 participants
@chmac @amberleyromo @kakadiadarpan @shannonbux