fix(gatsby-plugin-manifest): favicon path respects hybrid mode

[zauni]

In hybrid mode, you can have a different path for the icons. This path is used when the icons get generated, but the favicon <link> tag is not using it. This fixes it.

[pieh]

Could we move

gatsby/packages/gatsby-plugin-manifest/src/gatsby-node.js

Line 38 in 1e1c576

manifest.icons[0].src.substring(0, manifest.icons[0].src.lastIndexOf(`/`))

to something like utils file, so implementation is not duplicated in 2 (or more files)?

[zauni]

You are right! And I remembered that Node already has a function to get the folder of a path: dirname

But is it possible to require the path module from node in gatsby-ssr.js?

[zauni]

Hm... I realised now that not only the folder could be different, but also the filename, so I have to change that also. I will make a new commit later to account for that.

[pieh]

Thanks @zauni!