Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in Wordpress Queue Loses Stack Trace #9283

Closed
justsml opened this issue Oct 21, 2018 · 0 comments · Fixed by #9284
Closed

Error in Wordpress Queue Loses Stack Trace #9283

justsml opened this issue Oct 21, 2018 · 0 comments · Fixed by #9284

Comments

@justsml
Copy link
Contributor

justsml commented Oct 21, 2018 •
edited

Description

This is a minor issue around error visibility.

Here's how Bluebird's warning about the issue shows up:

image

Warning: a promise was rejected with a non-error: [object String]

To fix this, rej(string) must be called with new Error(string) instead.

PR, coming soon. ❤️
justsml added a commit to justsml/gatsby that referenced this issue Oct 21, 2018
@justsml
Promise issue from gatsbyjs#9283
14d7be6 
Fixes gatsbyjs#9283
@justsml justsml mentioned this issue Oct 21, 2018
Merged
pieh pushed a commit that referenced this issue Oct 22, 2018
@justsml @pieh
fix: throw error instead of string (#9284)
bcdd834 
Fixes #9283

## Description

This is a minor issue around error visibility.

Here's how Bluebird's warning about the issue shows up:

![image](https://user-images.githubusercontent.com/397632/47270777-d47ce680-d52d-11e8-9a1d-1812a9837d5a.png)

`Warning: a promise was rejected with a non-error: [object String]`

To fix this, `rej(string)` must be called with a `new Error(string)` instead.
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019
@justsml @gpetrioli
fix: throw error instead of string (gatsbyjs#9284)
68287bb 
Fixes gatsbyjs#9283

## Description

This is a minor issue around error visibility.

Here's how Bluebird's warning about the issue shows up:

![image](https://user-images.githubusercontent.com/397632/47270777-d47ce680-d52d-11e8-9a1d-1812a9837d5a.png)

`Warning: a promise was rejected with a non-error: [object String]`

To fix this, `rej(string)` must be called with a `new Error(string)` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: throw error instead of string justsml/gatsby
1 participant
@justsml