Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image as link has horizontal line in background #9593

Closed
ygd opened this issue Oct 31, 2018 · 2 comments · Fixed by #9623
Closed

Image as link has horizontal line in background #9593

ygd opened this issue Oct 31, 2018 · 2 comments · Fixed by #9623
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby

Comments

@ygd
Copy link

ygd commented Oct 31, 2018

Description

The authors image in a blogpost is a link. It inherits link tag stylings which draws a border in the background.

Steps to reproduce

Open a blogpost and hover over the authors image.

This is how it looks.
bildschirmfoto 2018-10-31 um 08 45 28

Expected result

No borders in background for images in link tags.

Actual result

Border in background.

Environment

production.
@kakadiadarpan kakadiadarpan added type: bug An issue or pull request relating to a bug in Gatsby help wanted Issue with a clear description that the community can help with. status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. status: inkteam to review and removed help wanted Issue with a clear description that the community can help with. labels Oct 31, 2018
@aravindballa
Copy link
Contributor

Can I grab this?

@gurtjun gurtjun mentioned this issue Nov 1, 2018
Merged
@gurtjun
Copy link
Contributor

gurtjun commented Nov 1, 2018

I already had a fix locally but did not push it 'till now.

Should have assigned it to me, sorry.

DSchau pushed a commit that referenced this issue Nov 1, 2018
@gurtjun @DSchau
Remove background, box-shadow and border-bottom from author image (95…
56eb023 
…93) (#9623)

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

Fixes #9593
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this issue Jan 22, 2019
@gurtjun @gpetrioli
Remove background, box-shadow and border-bottom from author image (95…
274cbf1 
…93) (gatsbyjs#9623)

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->

Fixes gatsbyjs#9593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove background, box-shadow and border-bottom from author image (9593) gurtjun/gatsby
4 participants
@ygd @aravindballa @kakadiadarpan @gurtjun