feat(gatsby-source-filesystem): keep original name of remote files along with hash

[hbish]

This PR is to enhance createRemoteFileNode to retain the filename of the remote file. Additional details in #9539 and prismicio/prismic-gatsby#40

cc: @DSchau sorry I messed up the other PR #9601, had to raise another.

[LekoArts]

Before merging this should be discussed:
#9539 (comment)

[LekoArts]

@hbish Do you have time to make the changes to the PR? Namely putting the hash into a folder and the file into the folder as @pieh suggested in the issue?

[hbish]

@LekoArts I got back from holiday earlier this week. Just made the change. Please review.

[LekoArts]

LGTM

[LekoArts]

Letting @DSchau have a look at it, too 👍

[LekoArts]

@DSchau @pieh BUMP ^

[jkjustjoshing]

I've needed to put off releasing the product I'm working on awaiting this functionality. Any update on when it'll be able to get reviewed and added to a new version @DSchau @pieh?

[pieh]

@jkjustjoshing do You use publicURL to get link to your files? If so there will be additional change needed in here:

gatsby/packages/gatsby-source-filesystem/src/extend-file-node.js

Lines 17 to 19 in 668aa9f

	const fileName = `${file.name}-${file.internal.contentDigest}${
	details.ext
	}`

[pieh]

There is some path problem with this:

/Users/misiek/dev/gatsby/examples/using-drupal/5bdb23fc01e4c72c3a39c6f1890ff2c3/.cache/gatsby-source-filesystem/bacon-themed_dinner.jpg

digest should be inside .cache/gatsby-source-filesystem, right now it creates multiple extra directories in project root dir

[pieh]

I'll push fix for this to get this merged

Issues need to be solved

[pieh]

Thanks @hbish!

[gatsbot]

Holy buckets, @hbish — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

[jbolda]

This has appeared to introduce a slight regression. In gatsby-source-airtable, the api delivers files with symbols/spaces/etc URI encoded and it appears that this update no longer handles it as it did previously. I don't have time right now to dig in further, but it appears that some functions expect it decoded and some don't?

This example reproduces the issue. There are multiple photos where this errors, but I know specifically the last one errors out. Unfortunately, to run it, you need an airtable account to get an API key, but you can just copy over the template. Essentially, the photo never loads because the url to the photo is incorrect.

[LekoArts]

@jbolda #10650 might help?

[jbolda]

@LekoArts I believe you are correct 👍

[oorestisime]

FYI #11037