Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): upgrade autoprefixer #10062

Merged
merged 2 commits into from
Feb 8, 2019
Merged

chore(gatsby): upgrade autoprefixer #10062

merged 2 commits into from
Feb 8, 2019

Conversation

alexandernanberg
Copy link
Contributor

Upgrade autoprefixer to the latest major version. Release notes.

@alexandernanberg alexandernanberg requested a review from a team as a code owner November 21, 2018 10:36
@alexandernanberg alexandernanberg changed the title chore(gatsby): upgrade autoprefixer feat(gatsby): upgrade autoprefixer Nov 21, 2018
@@ -17,7 +17,7 @@
"@babel/runtime": "^7.0.0",
"@babel/traverse": "^7.0.0",
"@reach/router": "^1.1.1",
"autoprefixer": "^8.6.5",
"autoprefixer": "^9.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version is 9.3.1: https://www.npmjs.com/package/autoprefixer I'm curious why we are specifying 9.0.0 if we are updating it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will resolve to that version anyways, the caret before tells yarn/npm to use any version that starts with 9 in this case. I could change it tho, just have a habit of doing it like this 😁

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reply. I leave it up to you on the exact version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandernanberg could you bump ^9.3.1 it doesn't matter if it's unnecessary or not but it gives us a sign what version we actually tested.

Copy link
Contributor

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if conflicts resolved.

@DSchau DSchau changed the title feat(gatsby): upgrade autoprefixer chore(gatsby): upgrade autoprefixer Jan 3, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm doing the last sanity checks to make sure we haven't broken anything. Autoprefixer drops support for node 4 & 9 so this might be a breaking change. We're not testing node 9 as it's not part of the LTS family so I think we're good here.

@wardpeet wardpeet merged commit 91341b4 into gatsbyjs:master Feb 8, 2019
@alexandernanberg alexandernanberg deleted the chore/upgrade-autoprefixer branch February 8, 2019 10:39
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants