-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby): upgrade autoprefixer #10062
chore(gatsby): upgrade autoprefixer #10062
Conversation
packages/gatsby/package.json
Outdated
@@ -17,7 +17,7 @@ | |||
"@babel/runtime": "^7.0.0", | |||
"@babel/traverse": "^7.0.0", | |||
"@reach/router": "^1.1.1", | |||
"autoprefixer": "^8.6.5", | |||
"autoprefixer": "^9.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest version is 9.3.1: https://www.npmjs.com/package/autoprefixer I'm curious why we are specifying 9.0.0 if we are updating it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will resolve to that version anyways, the caret before tells yarn/npm to use any version that starts with 9 in this case. I could change it tho, just have a habit of doing it like this 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reply. I leave it up to you on the exact version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexandernanberg could you bump ^9.3.1
it doesn't matter if it's unnecessary or not but it gives us a sign what version we actually tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if conflicts resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm doing the last sanity checks to make sure we haven't broken anything. Autoprefixer drops support for node 4 & 9 so this might be a breaking change. We're not testing node 9 as it's not part of the LTS family so I think we're good here.
Upgrade autoprefixer to the latest major version. [Release notes](https://github.com/postcss/autoprefixer/releases/tag/9.0.0).
Upgrade autoprefixer to the latest major version. Release notes.