Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #10306

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Update index.md #10306

merged 1 commit into from
Dec 5, 2018

Conversation

wesleylhandy
Copy link
Contributor

Update imports statements to reflect emotion/core instead of react-emotion and the commensurate use of css property rather than className. Also added an explanatory note on the graphql sort statement that there are three underscores, instead of two, which the eyes might only see.

Update imports statements to reflect `emotion/core` instead of `react-emotion` and the commensurate use of `css` property rather than `className`. Also added an explanatory note on the `graphql` sort statement that there are three underscores, instead of two, which the eyes might only see.
@wesleylhandy wesleylhandy requested a review from a team December 5, 2018 18:18
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DSchau DSchau merged commit d3b0454 into gatsbyjs:master Dec 5, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 5, 2018

Holy buckets, @wesleylhandy — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@wesleylhandy wesleylhandy deleted the patch-1 branch December 5, 2018 18:26
@shannonbux
Copy link
Contributor

@DSchau is this change because of emotion v10? Just want to make sure we're consistent with which version we use in the tutorial. #10263 seems to conclude that we should stick with v9

@DSchau
Copy link
Contributor

DSchau commented Dec 6, 2018

@shannonbux #10263 is basically invalid and I should probably close it out. It was created when we hadn't released the new plugin and added compatibility with emotion 10.

m-allanson added a commit to Bouncey/gatsby that referenced this pull request Dec 7, 2018
* master: (1595 commits)
  chore: update link for react-gatsby-firebase-authentication (gatsbyjs#10314)
  fix(www): Awesome Gatsby sidebar link (gatsbyjs#10313)
  Add thijs koerselman to creators list (gatsbyjs#10303)
  chore(release): Publish
  fix(gatsby-plugin-emotion): allow for React.Fragment shorthand syntax (gatsbyjs#10291)
  feat(www): Update starter cards (gatsbyjs#10258)
  Update index.md (gatsbyjs#10307)
  Update index.md (gatsbyjs#10306)
  Add thijs koerselman portfolio to sites list (gatsbyjs#10304)
  chore(release): Publish
  fix(gatsby): don't remount matchPath pages (gatsbyjs#10261)
  chore(release): Publish
  feat(gatsby-source-contentful): enable RichText for all users (gatsbyjs#10301)
  docs(tutorial): update 404 screenshot (gatsbyjs#10295)
  feat(gatsby-plugin-typescript): allow specifying babel preset options (gatsbyjs#10248)
  docs(gatsby-plugin-sass): fix typo in docs (gatsbyjs#10292)
  fix(ci): actually only run tests on non-docs changes (gatsbyjs#10287)
  fix(blog): rename for correct date in link (gatsbyjs#10290)
  Adds a more descriptive link purpose (gatsbyjs#9266)
  fix(www): comment out down showcase site
  ...
m-allanson added a commit to kaoDev/gatsby that referenced this pull request Dec 7, 2018
* master: (870 commits)
  fix(graphql-skip-limit): declare `graphql` peer dependency (gatsbyjs#10305)
  fix(gatsby-plugin-offline): gracefully degrade if appshell isn't precached (gatsbyjs#10329)
  Service workers note (gatsbyjs#10276)
  fix(docs): link fixes, podcast addition (gatsbyjs#10332)
  feat(docs): Create clearer pathways in docs (gatsbyjs#9898)
  feat(www): Rename community section to creators (gatsbyjs#10312)
  docs(graphql-reference): clarify filtering using comma/and operator (gatsbyjs#10321)
  chore(release): Publish
  feat(gatsby-plugin-sass): Support Dart SASS (gatsbyjs#10159)
  fix(gatsby-source-drupal): use basic auth credentials to fetch remote files as well. (gatsbyjs#10302)
  fix(gatsby-source-filesystem): allow empty password for basic auth in createRemoteFileNode (gatsbyjs#10280)
  docs(gatsby-remark-prismjs): Use Gatsby V2 project structure (gatsbyjs#10059)
  chore: update link for react-gatsby-firebase-authentication (gatsbyjs#10314)
  fix(www): Awesome Gatsby sidebar link (gatsbyjs#10313)
  Add thijs koerselman to creators list (gatsbyjs#10303)
  chore(release): Publish
  fix(gatsby-plugin-emotion): allow for React.Fragment shorthand syntax (gatsbyjs#10291)
  feat(www): Update starter cards (gatsbyjs#10258)
  Update index.md (gatsbyjs#10307)
  Update index.md (gatsbyjs#10306)
  ...
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Update imports statements to reflect `emotion/core` instead of `react-emotion` and the commensurate use of `css` property rather than `className`. Also added an explanatory note on the `graphql` sort statement that there are three underscores, instead of two, which the eyes might only see.

<!--
  Q. Which branch should I use for my pull request?
  A. Your best bet is to go for `master`. If you are unsure, ask in the PR, and a Gatsby mantainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants