Exit with the right status when build fails #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the build fails, exit with the failure code (1). This is done by throwing any errors from the build instead of just logging them to stdout like before. The correct exit code is important when running Gatsby in a CI build, for example. You want the build to fail so you don't deploy the site, if it didn't build successfully.
KyleAMathews
added a commit
that referenced
this pull request
Dec 20, 2015
Exit with the right status when build fails Conflicts: lib/utils/build.js
|
Thanks! |
gauravv-shukla
added a commit
to gauravv-shukla/gatsby
that referenced
this pull request
Sep 25, 2020
Acroyoga->acroyoga(always lowercase)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the build fails, exit with the failure code (1). This is done by
throwing any errors from the build instead of just logging them to
stdout like before.
The correct exit code is important when running Gatsby in a CI build,
for example. You want the build to fail so you don't deploy the site,
if it didn't build successfully.