Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(gatsby-image): mention how to avoid stretched images in fluid #10495

Merged
merged 5 commits into from
Jan 10, 2019
Merged

docs(gatsby-image): mention how to avoid stretched images in fluid #10495

merged 5 commits into from
Jan 10, 2019

Conversation

oorestisime
Copy link
Contributor

Following up on PR #10460 with a docs improvement.
I am not sure there are other places this needs to be mentioned.

LekoArts
LekoArts reviewed Dec 16, 2018
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some smaller changes needed. Looking good!

packages/gatsby-image/README.md Outdated Show resolved Hide resolved
packages/gatsby-image/README.md Outdated Show resolved Hide resolved
@pieh
Copy link
Contributor

pieh commented Dec 17, 2018

It probably should be mentioned that default fragments for fluid queries don't have presentationWidth field in them and people would need to adjust their queries for that. So maybe we could move this to "Fluid" queries or Some other stuff to be aware of sections?

@oorestisime
Copy link
Contributor Author

Would it make sense to include it in the fragments? Having used the workaround a few times it would make life a bit easier and i am not sure i see a reason not to.

LekoArts and others added 3 commits December 17, 2018 16:10
@LekoArts @oorestisime
Update packages/gatsby-image/README.md
99ee614 
Co-Authored-By: oorestisime <oorestisime@gmail.com>
@LekoArts @oorestisime
Update packages/gatsby-image/README.md
5cd9601 
Co-Authored-By: oorestisime <oorestisime@gmail.com>
@oorestisime
Move documentation to fluid component and add fragmnets note
3733db2
LekoArts
LekoArts reviewed Jan 9, 2019
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one comment this looks good to me. I'd suggest merging this and putting the discussion of whether to modify the fragment or not into its own issue 👍

packages/gatsby-image/README.md Outdated Show resolved Hide resolved
@LekoArts @oorestisime
Update packages/gatsby-image/README.md
792fec9 
Co-Authored-By: oorestisime <oorestisime@gmail.com>
@LekoArts
Copy link
Contributor

@pieh Would be good to go IMO

@pieh pieh changed the title Mention how to avoid stretched images in fluid gatsby-image docs(gatsby-image): mention how to avoid stretched images in fluid Jan 10, 2019
pieh
pieh approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oorestisime!

@pieh pieh merged commit 6c27086 into gatsbyjs:master Jan 10, 2019
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@oorestisime @gpetrioli
docs(gatsby-image): mention how to avoid stretched images in fluid (g…
d4209f8 
…atsbyjs#10495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts left review comments

@pieh pieh pieh approved these changes

@sutter sutter sutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oorestisime @pieh @LekoArts @sutter