Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct capitalization for component imports in the blog starter #10671

Merged
merged 1 commit into from
Dec 27, 2018
Merged

fix: correct capitalization for component imports in the blog starter #10671

merged 1 commit into from
Dec 27, 2018

Conversation

builtbydamian
Copy link
Contributor

Description

Using the blog starter currently fails due to the wrong capitalization being used in the file path for improts, resulting in errors such as these during build

These relative modules were not found:

* ../components/bio in ./src/pages/index.js, ./src/templates/blog-post.js
* ../components/layout in ./src/pages/404.js, ./src/pages/index.js and 1 other

This PR fixes the capitalization (changing components/bio to components/Bio) on the affected pages.

The other starters are not affected by this problem.

@builtbydamian
fix: correct capitalization for component imports in the blog starter
400908b 
A previous change set them to lower case which caused the built to fail on case sensitive file systems.
@pieh pieh merged commit c3bd125 into gatsbyjs:master Dec 27, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 27, 2018

Holy buckets, @builtbydamian — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@LekoArts LekoArts mentioned this pull request Dec 27, 2018
Closed
This was referenced Dec 27, 2018
Merged
Merged
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@builtbydamian @gpetrioli
fix: correct capitalization for component imports in the blog starter (…
f3b2cd5 
…gatsbyjs#10671)
DSchau added a commit that referenced this pull request Feb 5, 2019
@DSchau
chore: standardize on lowercase/dasherized file names (#10691)
50920c1 
## Description

I've seen some tweets that indicate that _sometimes_ there can be confusion as to whether to use uppercase or lowercase conventions for React component file names.

This isn't specific to Gatsby, but we can resolve some of this by documenting a consistent format, and for that I'd recommend that we consistently document lowercase with a dash separating terms (dasherized, e.g. NavBar is `nav-bar.js`). This is what we use in the starters (e.g. src/components/header.js instead of src/components/Header.js) outside of the blog starter--which has been normalized in this PR.

I've also done a simple find and replace for usage of these (e.g. src/components/Bio.js -> src/components/bio.js) so that the documentation matches the usage. There are additional uppercase components (e.g. src/components/SEO.js) but I left those as is, since the usage of them where referenced is also uppercase.

## Related Issues

Sorta related to #10671 as well as my comment [here](#10690 (comment))
gatsbybot pushed a commit to gatsbyjs/gatsby-starter-blog that referenced this pull request Feb 5, 2019
chore: standardize on lowercase/dasherized file names (#10691)
1fc1513 
## Description

I've seen some tweets that indicate that _sometimes_ there can be confusion as to whether to use uppercase or lowercase conventions for React component file names.

This isn't specific to Gatsby, but we can resolve some of this by documenting a consistent format, and for that I'd recommend that we consistently document lowercase with a dash separating terms (dasherized, e.g. NavBar is `nav-bar.js`). This is what we use in the starters (e.g. src/components/header.js instead of src/components/Header.js) outside of the blog starter--which has been normalized in this PR.

I've also done a simple find and replace for usage of these (e.g. src/components/Bio.js -> src/components/bio.js) so that the documentation matches the usage. There are additional uppercase components (e.g. src/components/SEO.js) but I left those as is, since the usage of them where referenced is also uppercase.

## Related Issues

Sorta related to gatsbyjs/gatsby#10671 as well as my comment [here](gatsbyjs/gatsby#10690 (comment))
ish-xyz pushed a commit to ish-xyz/ish-ar.io that referenced this pull request Dec 5, 2019
chore: standardize on lowercase/dasherized file names (#10691)
87a6a22 
## Description

I've seen some tweets that indicate that _sometimes_ there can be confusion as to whether to use uppercase or lowercase conventions for React component file names.

This isn't specific to Gatsby, but we can resolve some of this by documenting a consistent format, and for that I'd recommend that we consistently document lowercase with a dash separating terms (dasherized, e.g. NavBar is `nav-bar.js`). This is what we use in the starters (e.g. src/components/header.js instead of src/components/Header.js) outside of the blog starter--which has been normalized in this PR.

I've also done a simple find and replace for usage of these (e.g. src/components/Bio.js -> src/components/bio.js) so that the documentation matches the usage. There are additional uppercase components (e.g. src/components/SEO.js) but I left those as is, since the usage of them where referenced is also uppercase.

## Related Issues

Sorta related to gatsbyjs/gatsby#10671 as well as my comment [here](gatsbyjs/gatsby#10690 (comment))
leonhiat added a commit to leonhiat/gatsby-starter-blog that referenced this pull request Oct 31, 2023
@leonhiat
chore: standardize on lowercase/dasherized file names (#10691)
bc73f98 
## Description

I've seen some tweets that indicate that _sometimes_ there can be confusion as to whether to use uppercase or lowercase conventions for React component file names.

This isn't specific to Gatsby, but we can resolve some of this by documenting a consistent format, and for that I'd recommend that we consistently document lowercase with a dash separating terms (dasherized, e.g. NavBar is `nav-bar.js`). This is what we use in the starters (e.g. src/components/header.js instead of src/components/Header.js) outside of the blog starter--which has been normalized in this PR.

I've also done a simple find and replace for usage of these (e.g. src/components/Bio.js -> src/components/bio.js) so that the documentation matches the usage. There are additional uppercase components (e.g. src/components/SEO.js) but I left those as is, since the usage of them where referenced is also uppercase.

## Related Issues

Sorta related to gatsbyjs/gatsby#10671 as well as my comment [here](gatsbyjs/gatsby#10690 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@builtbydamian @ZYSzys @pieh