fix(examples): GraphQL reference codesandbox issue #10807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
approved these changes
Jan 3, 2019
|
Codesandbox doesn't have access to that file (I think) |
|
It wasn't published yet I think |
|
Ah, I see. However I think Codesandbox will only restart the dev server (instance) if something changed on the repo. So if we don't change the PATH_PREFIX we'd need to change something else to trigger a new run. |
We'd need to upgrade to the version of gatsby that contains this change--so maybe we do that in this PR? |
LekoArts
changed the title
|
Didn't work out as expected, |
|
@LekoArts I'm not sure the change has been published yet. The |
|
I just published .84 with the change |
m-allanson
added a commit
that referenced
this pull request
Jan 4, 2019
DSchau
pushed a commit
that referenced
this pull request
Jan 4, 2019
## Description A version of Gatsby with the correct fix has been published, this is the same as #10807
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
* Remove PATH_PREFIX from graphql-reference-example * update package instead
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
## Description A version of Gatsby with the correct fix has been published, this is the same as gatsbyjs#10807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codesandbox apparently fails on that