Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-google-analytics): add support for google optimize experiment and variation id #10903

Merged
merged 1 commit into from
Jan 8, 2019
Merged

feat(gatsby-plugin-google-analytics): add support for google optimize experiment and variation id #10903

merged 1 commit into from
Jan 8, 2019

Conversation

rotexhawk
Copy link
Contributor

This PR adds support for google optimize experiment and variation id to make it possible to run server_side experiments. This works great with netlify because they have built-in split testing.

All tests passed when running yarn test

@pieh pieh changed the title Add support for google optimize experiment and variation id - google-analytics plugin feat(gatsby-plugin-google-analytics): add support for google optimize experiment and variation id Jan 8, 2019
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's neat feature of GA. Thanks @rotexhawk!

@pieh pieh merged commit 45ec012 into gatsbyjs:master Jan 8, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 8, 2019

Holy buckets, @rotexhawk — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@rotexhawk rotexhawk deleted the topics/google-analytics-optimize-server-side-experiment-support branch January 8, 2019 17:52
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants