Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-starter-blog): Fix global access to graphql in blog starter's 404 #10923

Merged
merged 1 commit into from
Jan 8, 2019
Merged

fix(gatsby-starter-blog): Fix global access to graphql in blog starter's 404 #10923

merged 1 commit into from
Jan 8, 2019

Conversation

sidharthachatterjee
Copy link
Contributor

Global access to graphql (which is deprecated) got added accidentally in https://github.com/gatsbyjs/gatsby/pull/10865/files

This fixes that and gets rids of the annoying warning in the output
screenshot 2019-01-08 22 52 33

@sidharthachatterjee sidharthachatterjee added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Jan 8, 2019
@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner January 8, 2019 17:23
DSchau
DSchau approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops; thanks!

@DSchau DSchau merged commit fdcbe65 into master Jan 8, 2019
@DSchau DSchau deleted the fix/global-access-to-graphql-in-404 branch January 8, 2019 17:24
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
@sidharthachatterjee @gpetrioli
fix(gatsby-starter-blog): Fix global access to graphql in blog starte…
5ae92d1 
…r's 404 (gatsbyjs#10923)

Global access to `graphql` (which is deprecated) got added accidentally in https://github.com/gatsbyjs/gatsby/pull/10865/files

This fixes that and gets rids of the annoying warning in the output
![screenshot 2019-01-08 22 52 33](https://user-images.githubusercontent.com/7701981/50847634-1af91900-1398-11e9-97f5-a5ea812fc873.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sidharthachatterjee @DSchau