Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-mongodb): sanitize name correctly #11294

Merged
merged 8 commits into from Mar 12, 2019

Conversation

harshil1712
Copy link
Contributor

Description

This is the PR for issue #11277. It fixes the sanitizeName error.

Related Issues

Related to #11277

@DSchau DSchau changed the title gatsby-source-mongodb sanitizeName fix fix(gatsby-source-mongodb): sanitize name correctly Jan 25, 2019
DSchau
DSchau previously requested changes Jan 25, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Thanks so much for the PR!

packages/gatsby-source-mongodb/src/__tests__/utility.js Outdated Show resolved Hide resolved
packages/gatsby-source-mongodb/src/__tests__/utility.js Outdated Show resolved Hide resolved
packages/gatsby-source-mongodb/src/utility.js Outdated Show resolved Hide resolved
@harshil1712
Copy link
Contributor Author

@DSchau thank you so much for the feedback! Working on it.

@harshil1712
Copy link
Contributor Author

@DSchau may you please review the changes? Thank You.

@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Jan 31, 2019
@DSchau
Copy link
Contributor

DSchau commented Feb 7, 2019

@harshil1712 can you merge upstream/master into this repo and then fix the merge conflict? Otherwise one of us can!

git fetch upstream master
git merge upstream/master

then fix the conflict in packages/gatsby-source-mongodb/src/gatsby-node.js

Thanks so much!

@harshil1712
Copy link
Contributor Author

@DSchau I tried the steps. Please review it 😄

@harshil1712
Copy link
Contributor Author

@DSchau the lodash library is being used. Please refer line 76 and 77

As suggested, since lodash is not being used, it is not required

Co-Authored-By: harshil1712 <ghagrawal17@gmail.com>
@harshil1712
Copy link
Contributor Author

@DSchau I have made the changes as you suggested. Please review it. Thank you.

@wardpeet wardpeet added status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response Additional information has been requested from the author labels Feb 28, 2019
@wardpeet wardpeet removed the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Mar 12, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated and merged with master! Ready to merge!

@wardpeet wardpeet dismissed DSchau’s stale review March 12, 2019 13:03

Everything got handled :)

@wardpeet wardpeet merged commit 731dd60 into gatsbyjs:master Mar 12, 2019
@gatsbot
Copy link

gatsbot bot commented Mar 12, 2019

Holy buckets, @harshil1712 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants