-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starters): Added gatsby-starter-developer-blog to starters list #11544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great and thanks for the submission! Left a comment re: the features.
- Technology | ||
- SEO | ||
- Web Development | ||
features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we clean these up a little bit? Some are too verbose, others are questionably useful, for example:
- What is an
Archive
feature? - We can probably just drop the tailing stuff on
SEO optimization ...
and call itSEO
- Is
Roboto.txt
supposed to berobots.txt
support? - FeedRSS ->
RSS Feed
? - etc.
I'd just ask to take another look at these and ensure they're simplified and maximally effective. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dustin, thank you for the review! I've tried to simplify features list, I hope that it's right now.
Co-Authored-By: lgcolella <32601631+lgcolella@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Holy buckets, @lgcolella — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
No description provided.