Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starters): Added gatsby-starter-developer-blog to starters list #11544

Merged
merged 6 commits into from
Feb 8, 2019

Conversation

luigi-colella
Copy link
Contributor

No description provided.

@luigi-colella luigi-colella requested a review from a team February 4, 2019 17:50
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great and thanks for the submission! Left a comment re: the features.

- Technology
- SEO
- Web Development
features:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clean these up a little bit? Some are too verbose, others are questionably useful, for example:

  • What is an Archive feature?
  • We can probably just drop the tailing stuff on SEO optimization ... and call it SEO
  • Is Roboto.txt supposed to be robots.txt support?
  • FeedRSS -> RSS Feed ?
  • etc.

I'd just ask to take another look at these and ensure they're simplified and maximally effective. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dustin, thank you for the review! I've tried to simplify features list, I hope that it's right now.

docs/starters.yml Outdated Show resolved Hide resolved
Co-Authored-By: lgcolella <32601631+lgcolella@users.noreply.github.com>
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DSchau DSchau merged commit 0594c69 into gatsbyjs:master Feb 8, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 8, 2019

Holy buckets, @lgcolella — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants