Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove extra bottom margin in figures during develop #11683

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

jlengstorf
Copy link
Contributor

@jlengstorf jlengstorf commented Feb 10, 2019

Before this fix, using figure with figcaption in develop added extra margin to the bottom of img tags, which made the captions look weird and disconnected from the image. This fixes that.

screen shot 2019-02-10 at 1 01 38 pm

@jlengstorf jlengstorf requested a review from a team as a code owner February 10, 2019 21:00
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m-allanson m-allanson merged commit 38a5af7 into gatsbyjs:master Feb 12, 2019
@jlengstorf jlengstorf deleted the style/figcaption-develop branch February 12, 2019 15:29
gurpreet-hanjra pushed a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants