docs(creating-and-modifying-pages): remove unnecessary promise #11697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also added a "note" indicating that you can still use this function asynchronous.
|
Change made after this Twitter exchange https://twitter.com/gatsbyjs/status/1095068494075326465 |
m-allanson
approved these changes
Feb 12, 2019
|
Oops, the linting failed - I'll update this quickly. |
wardpeet
added
the
type: documentation
wardpeet
changed the title
gurpreet-hanjra
pushed a commit
to gurpreet-hanjra/gatsby
that referenced
this pull request
Feb 14, 2019
…yjs#11697) * Remove unnecessary promise wrapper in example I also added a "note" indicating that you can still use this function asynchronous. * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added a "note" indicating that you can still use this function asynchronously. Instead of (or in addition to) this, we might want to add a true async example.