Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add egghead lesson to quickstart #11699

Merged
merged 4 commits into from
Feb 12, 2019

Conversation

jlengstorf
Copy link
Contributor

@calcsam had a good idea to add video versions of some of our commonly visited docs pages.

This adds a video walkthrough following the quick start from our docs to the quick start itself.

@jlengstorf jlengstorf added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Feb 12, 2019
@jlengstorf jlengstorf requested review from marcysutton, calcsam and a team February 12, 2019 00:18
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do these need approval (from Egghead) or are they good to merge?

@jlengstorf
Copy link
Contributor Author

Still waiting on approval from egghead. Once we have that plus the 👍 from @marcysutton, it should be good to go.

@jlengstorf
Copy link
Contributor Author

Oh, wait — this one is approved. It's #11700 that needs approval from egghead.

So we just need @marcysutton on this one.

@@ -6,6 +6,12 @@ This quick start is intended for intermediate to advanced developers. For a gent

## Use the Gatsby CLI

<iframe class="egghead-video" width=600 height=348 src="https://egghead.io/lessons/gatsby-quick-start-with-gatsby-create-develop-and-build-gatsby-sites-from-the-command-line/embed" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a title to this iframe and it's good to go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jlengstorf
Copy link
Contributor Author

@marcysutton title added! (I added them to #11700 as well.)

Let me know if you need anything else.

@jlengstorf jlengstorf merged commit 0baa034 into gatsbyjs:master Feb 12, 2019
@jlengstorf jlengstorf deleted the docs/egghead-quickstart branch February 12, 2019 21:41
gurpreet-hanjra pushed a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 14, 2019
* docs: add egghead lesson to quickstart

* docs: add title to iframe for a11y
m-allanson added a commit to gurpreet-hanjra/gatsby that referenced this pull request Feb 15, 2019
* master: (76 commits)
  chore(release): Publish
  Update relay version once again (gatsbyjs#11767)
  Update CHANGELOG.md (gatsbyjs#11764)
  chore(release): Publish
  Move to @gatsbyjs scoped version of yarn (gatsbyjs#11759)
  fix(blog): 2019-01-01 json code blocks (gatsbyjs#11750)
  fix(starters): update dependency gatsby to ^2.1.0 (gatsbyjs#11745)
  fix(starters): update dependency prop-types to ^15.7.2 (gatsbyjs#11748)
  feat(showcase): add Incremental.com.au (gatsbyjs#11729)
  feat(starters): add starter magicsoup.io (gatsbyjs#11670)
  docs(gatsby): Add documentation for useStaticQuery (gatsbyjs#11741)
  chore(release): Publish
  feat(gatsby): add useStaticQuery hook (gatsbyjs#11588)
  chore(release): Publish
  chore(docs): reword CSS in JS docs for clarity (gatsbyjs#11439)
  chore: Upgrade Prettier related packages to the latest (gatsbyjs#11735)
  fix(core): added event source polyfill in develop to fix IE/edge hmr (gatsbyjs#11582)
  chore: minify svg husky hook (gatsbyjs#10560)
  docs: add videos for Gatsby Link + rewrite for flow (gatsbyjs#11700)
  docs: add egghead lesson to quickstart (gatsbyjs#11699)
  ...
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
* docs: add egghead lesson to quickstart

* docs: add title to iframe for a11y
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants