Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): clarify that Gatsby can be hosted anywhere #11728

Merged
merged 3 commits into from
Feb 15, 2019
Merged

chore(docs): clarify that Gatsby can be hosted anywhere #11728

merged 3 commits into from
Feb 15, 2019

Conversation

saranshkataria
Copy link
Contributor

fixes #11721

@saranshkataria saranshkataria requested a review from a team as a code owner February 13, 2019 01:55
@saranshkataria saranshkataria requested a review from a team February 13, 2019 01:55
DSchau
DSchau suggested changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left a comment/request for change.

Additionally, looks like some extra commits came along for the ride 🙃

docs/docs/deploying-and-hosting.md Outdated
@@ -8,3 +8,5 @@ Getting your shiny new Gatsby site onto the cloud is probably the first thing yo
In this section you'll find answers to questions about dealing with app routes that aren't at the root of your domain with `path prefixes`, as well as how to deploy to countless hosting solutions such as [Netlify](https://www.netlify.com/), [AWS Amplify Console](https://console.amplify.aws), and [GitHub Pages](https://pages.github.com/). As well as what's necessary to make sure you're fully prepared for a deploy! 🚀

[[guidelist]]

**Note:** Gatsby deployment is not limited to the above mentioned list and you can deploy anywhere you wish to as long as you setup appropriate [caching rules](https://www.gatsbyjs.org/docs/caching/) for best performance of your site.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this clearer by putting this up top? I think it's important enough to be explicit here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning that the list down below is incomplete without the list in context seems a bit odd to me I guess

Copy link
Contributor

@DSchau DSchau Feb 13, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right - so you wouldn't move this exact content up, you'd move a similar disclaimer up to the top! i.e. something like (feel free to re-word this, wrote this quickly)

The result of Gatsby's build process is static content: HTML, CSS, JavaScript, images, and more that power your great web application. This content that is produced by this build process is incredibly easy and affordable to host with any provider. We have several guides below for hosting with particular providers, but this list is by no means exhaustive. Whether you're deploying with AWS, Netlify, or something in between--switching to static content makes deploying a trivial concern.

@DSchau DSchau changed the title Hosting documentation change chore(docs): clarify that Gatsby can be hosted anywhere Feb 13, 2019
@saranshkataria
Copy link
Contributor Author

Additionally, looks like some extra commits came along for the ride 🙃

Not sure how that happened. Though those have been merged in but I will create a cleaner PR having just the documentation change

@DSchau
Copy link
Contributor

DSchau commented Feb 13, 2019 •
edited

@saranshkataria

git reset HEAD~3
git stash
git checkout c9f5d75 docs/docs/deploying-and-hosting.md
# add the commit
git push origin +hosting-documentation-change

should do the trick!

@saranshkataria
Copy link
Contributor Author

@DSchau thanks, that worked! Not sure why the tests are failing though

@wardpeet wardpeet added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Feb 15, 2019
@DSchau DSchau merged commit e385fe0 into gatsbyjs:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau requested changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: clarify gatsby site can be hosted anywhere
3 participants
@saranshkataria @DSchau @wardpeet