Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starters): Add font smoothing #11751

Merged

Conversation

jahlherapath
Copy link
Contributor

This PR adds font smoothing via layout.css to the default gatsby starter theme.

@jahlherapath jahlherapath requested a review from a team as a code owner February 14, 2019 02:01
@jahlherapath jahlherapath force-pushed the add-font-smoothing-default-starter branch from 2940fe2 to 6012868 Compare February 14, 2019 03:18
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! So few questions/comments:

  1. Could you explain in a sentence or two why this is valuable?
    • In reading, looks like it makes text look a little nicer (yay); does this have any ill-effect on Windows vs. Mac?
  2. If this is worth doing (and it probably is!) may as well add it to all starters?

@jahlherapath
Copy link
Contributor Author

Thanks for the feedback! @DSchau

  1. Yeah it basically makes the text more legible and a good inclusion for sites with heaps of content. No issues between platforms.
  2. I could add to the other starters but there are no default styles (mostly inline).

@wardpeet
Copy link
Contributor

@DSchau windows will just ignore it as they don't support font smoothing. A workaround is using SVGs for windows but it can gives you weird issues as it's less flexible as woff, ...

By adding this it will only make osx a bit smoother and I'm all for it! 😄

@DSchau DSchau changed the title feat(default-starter): Add font smoothing feat(starters): Add font smoothing Feb 18, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!

@DSchau DSchau merged commit 9caa8e0 into gatsbyjs:master Feb 18, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 18, 2019

Holy buckets, @jahlherapath — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
This PR adds font smoothing via `layout.css` to the default gatsby starter theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants