-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starters): Add font smoothing #11751
feat(starters): Add font smoothing #11751
Conversation
2940fe2
to
6012868
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! So few questions/comments:
- Could you explain in a sentence or two why this is valuable?
- In reading, looks like it makes text look a little nicer (yay); does this have any ill-effect on Windows vs. Mac?
- If this is worth doing (and it probably is!) may as well add it to all starters?
Thanks for the feedback! @DSchau
|
@DSchau windows will just ignore it as they don't support font smoothing. A workaround is using SVGs for windows but it can gives you weird issues as it's less flexible as woff, ... By adding this it will only make osx a bit smoother and I'm all for it! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! Thanks!
Holy buckets, @jahlherapath — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
This PR adds font smoothing via `layout.css` to the default gatsby starter theme.
This PR adds font smoothing via
layout.css
to the default gatsby starter theme.