Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Update typings to contain PageRenderer & parsePath (fixes #11796) #11825

Merged
merged 2 commits into from
Feb 18, 2019
Merged

chore(gatsby): Update typings to contain PageRenderer & parsePath (fixes #11796) #11825

merged 2 commits into from
Feb 18, 2019

Conversation

jariz
Copy link
Contributor

@jariz jariz commented Feb 16, 2019

Description

Update typings to contain PageRenderer & parsePath (both of which were missing)

Related Issues

fixes #11796

@jariz jariz requested a review from a team as a code owner February 16, 2019 18:14
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @jariz 👍

Could you run prettier once on the file? That should get rid of the added semicolons.

@sidharthachatterjee sidharthachatterjee changed the title Update typings to contain PageRenderer & parsePath (fixes #11796) chore(gatsby): Update typings to contain PageRenderer & parsePath (fixes #11796) Feb 18, 2019
@sidharthachatterjee sidharthachatterjee merged commit fa6e327 into gatsbyjs:master Feb 18, 2019
@sidharthachatterjee
Copy link
Contributor

Thank you, @jariz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PageRenderer missing from typings
2 participants