Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm/npx commands - Tutorial #12273

Merged
merged 8 commits into from
Mar 7, 2019
Merged

Conversation

jameesy
Copy link
Contributor

@jameesy jameesy commented Mar 4, 2019

Description

Removal of npm and npx commands from the tutorial.

Related Issues

Fixes #12195

@jameesy jameesy requested a review from a team March 4, 2019 07:36
Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JABedford, this looks good to me 👍

DSchau
DSchau previously requested changes Mar 4, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

However - I think the tutorial will be fairly confusing if we don't explicitly mention (at least once) that the global needs to be installed.

This should live in tutorial/part-zero probably? Specifically in the Using the Gatsby CLI section, right?

@jameesy
Copy link
Contributor Author

jameesy commented Mar 5, 2019

Agreed. Will that do the trick?

@jameesy jameesy requested a review from DSchau March 7, 2019 08:03
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for handling this.

@KyleAMathews KyleAMathews dismissed DSchau’s stale review March 7, 2019 23:55

part-zero was updated

@KyleAMathews KyleAMathews merged commit 6f825c8 into master Mar 7, 2019
@KyleAMathews KyleAMathews deleted the jabedford-issue-12195 branch March 7, 2019 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants