Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-transformer-remark): Fix unreturned Promise warning #12303

Merged
merged 2 commits into from Mar 5, 2019
Merged

fix(gatsby-transformer-remark): Fix unreturned Promise warning #12303

merged 2 commits into from Mar 5, 2019

Conversation

sidharthachatterjee
Copy link
Contributor

No description provided.

@sidharthachatterjee sidharthachatterjee changed the title Fix unreturned Promise warning fix(gatsby-transformer-remark): Fix unreturned Promise warning Mar 5, 2019
KyleAMathews
KyleAMathews approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

DSchau
DSchau reviewed Mar 5, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we continue the promise chain with the cache.set instead?

ie delete the promise then return cache.set()

@sidharthachatterjee
Copy link
Contributor Author

@DSchau Does cache.set return a promise? Makes sense to return it then

@DSchau
Copy link
Contributor

DSchau commented Mar 5, 2019

It does, yeah! It should return the resolved value, but since we were returning null, shouldn’t really matter what we return!

@sidharthachatterjee
Copy link
Contributor Author

Yeah, makes sense. Changing that!

DSchau
DSchau approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gatsby Preview thanks you 👌

@sidharthachatterjee sidharthachatterjee merged commit 6f8f2c3 into master Mar 5, 2019
@sidharthachatterjee sidharthachatterjee deleted the fix/promise-not-returned branch March 5, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sidharthachatterjee @DSchau @KyleAMathews