Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #1232

Merged
merged 1 commit into from Jun 22, 2017
Merged

Update index.d.ts #1232

merged 1 commit into from Jun 22, 2017

Conversation

timsuchanek
Copy link
Contributor

@timsuchanek timsuchanek commented Jun 22, 2017

Fix Typing for gatsby-link. The .d.ts file mustn't include a semicolon after the expression and has to include the empty {}. Otherwise you get a TS1005 error. Tested with ts 2.2.1.

This is an example of the react-router typings: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-router/index.d.ts#L40

Fix Typing for gatsby-link
@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit 51f7fc7

https://app.netlify.com/sites/image-processing/deploys/594b902d6f4c501098f1c48f

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit 51f7fc7

https://app.netlify.com/sites/gatsbygram/deploys/594b902c6f4c501098f1c480

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit 51f7fc7

https://deploy-preview-1232--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit 51f7fc7

https://app.netlify.com/sites/gatsbyjs/deploys/594b902b6f4c501098f1c47d

@KyleAMathews KyleAMathews merged commit c4a2bd0 into gatsbyjs:1.0 Jun 22, 2017
@KyleAMathews
Copy link
Contributor

Thanks!

Would be great to get a Typescript example site added to the examples directory. Those are helpful both to help people learn but we also use them as integration tests as we build them on every PR.

@jlengstorf
Copy link
Contributor

Hiya @timsuchanek! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants