Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blog): add schema customization blog post release #12522

Conversation

DSchau
Copy link
Contributor

@DSchau DSchau commented Mar 12, 2019

Description

Opening for @freiksenet, since he's out on vacation!

Important to get this right--so 👀 appreciated!

Related Issues

@DSchau DSchau requested a review from a team March 12, 2019 19:28
@DSchau
Copy link
Contributor Author

DSchau commented Mar 12, 2019

@marcysutton only if you have time--but this is a pretty meaningful feature, so would love your 👀 here if you have a few minutes in the next few days!

Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few tweaky grammar things, and a question or two that would be good to answer for newbs. Great post!


## `createTypes`

`createTypes` can be used to define or fix your Node types GraphQL representation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a few words explaining what "Node types GraphQL representation" means in case people don't already know?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rephrased to

`createTypes` can be used to define, fix, or extend a Gatsby GraphQL type that represents some of your app's data.


## The Type Builder API

While `createTypes` accepts `graphql-js` types along with SDL string, we've also added an option to use `graphql-js` types so that user could create types with resolvers. However, `graphql-js` is pretty verbose and it's hard to refer to types that don't yet exist or don't exist in a current scope. Therefore, we decided to add another programmatic API, that combines brevity of SDL with flexibility of `graphql-js`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a newb question, but what is "SDL string"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a noob question--and we should always clarify our acronyms :) Will address!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a link to docs.

@calcsam
Copy link
Contributor

calcsam commented Mar 13, 2019

This looks great. Some thoughts:

marcysutton and others added 8 commits March 14, 2019 11:12
Co-Authored-By: DSchau <DSchau@users.noreply.github.com>
Co-Authored-By: DSchau <DSchau@users.noreply.github.com>
Co-Authored-By: DSchau <DSchau@users.noreply.github.com>
Co-Authored-By: DSchau <DSchau@users.noreply.github.com>
Co-Authored-By: DSchau <DSchau@users.noreply.github.com>
Co-Authored-By: DSchau <DSchau@users.noreply.github.com>
…au/gatsby into blog/releasing-schema-customization
@DSchau DSchau requested a review from marcysutton March 15, 2019 16:42
npm install gatsby --save
```

Next, continue reading below to see if any of the great, new features we've enabled scratch a particular itch. We feel very confident you're going to love these new features 💜
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

Suggested change
Next, continue reading below to see if any of the great, new features we've enabled scratch a particular itch. We feel very confident you're going to love these new features 💜
Next, continue reading below to see if any of the great, new features we've enabled scratch a particular itch. We feel very confident they will 💜

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Very open to tweaks here :))

@freiksenet
Copy link
Contributor

I'll make it merge to schema branch so we can publish as soon as we merge.

@freiksenet freiksenet changed the base branch from master to schema-refactor-new March 18, 2019 09:00
@freiksenet
Copy link
Contributor

I'll merge and continue in #11480 cause I can't commit here :(

@freiksenet freiksenet merged commit f46154b into gatsbyjs:schema-refactor-new Mar 18, 2019
@DSchau DSchau deleted the blog/releasing-schema-customization branch March 18, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants