Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-pugin-typography): headerComponents is now tolerant to null values #12551

Merged
merged 1 commit into from Mar 13, 2019
Merged

Conversation

danielkov
Copy link
Contributor

Description

As of right now null values may occur in headerComponents. This commit makes the typography plugin tolerant to these occurrences with simple null check.

Related Issues

Fixes #12549

@lannonbr lannonbr changed the title Closes #12549 gatsby-pugin-typography is now tolerant to null values fix(gatsby-pugin-typography): headerComponents is now tolerant to null values Mar 13, 2019
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielkov! 🙏

@pieh pieh merged commit a02ef30 into gatsbyjs:master Mar 13, 2019
@gatsbot
Copy link

gatsbot bot commented Mar 13, 2019

Holy buckets, @danielkov — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants