feat(gatsby-plugin-google-tagmanager): Add plugin option for custom dataLayer name #12783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muescha
reviewed
Mar 23, 2019
sidharthachatterjee
suggested changes
Mar 25, 2019
sidharthachatterjee
approved these changes
Mar 25, 2019
sidharthachatterjee
changed the title
|
Holy buckets, @spwisner — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
|
Published in gatsby-plugin-google-tagmanager@2.0.11 |
This was referenced Mar 28, 2019
DSchau
pushed a commit
that referenced
this pull request
Mar 28, 2019
…ed (#12920) <!-- Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> ## Description <!-- Write a brief description of the changes introduced by this PR --> For the `gatsby-plugin-google-tagmanager` this PR/release: #12783, has introduced a bug where by default the `'dataLayer'` is being set to `'datalayer'` (all lower case). Which means that by default this will not work with GTM. This PR just updates to use the correct form, `dataLayer` as the default. It is possibly the smallest PR I've ever made, but it will prevent a lot of people from being confused why they can't push to the dataLayer... ## Related Issues issue i filed for this: #12921
blairmcclenny
pushed a commit
to brandsoulmates/gatsby-plugin-google-tag-manager-ayz
that referenced
this pull request
Apr 14, 2021
…ed (#12920) <!-- Have any questions? Check out the contributing docs at https://gatsby.dev/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> ## Description <!-- Write a brief description of the changes introduced by this PR --> For the `gatsby-plugin-google-tagmanager` this PR/release: gatsbyjs/gatsby#12783, has introduced a bug where by default the `'dataLayer'` is being set to `'datalayer'` (all lower case). Which means that by default this will not work with GTM. This PR just updates to use the correct form, `dataLayer` as the default. It is possibly the smallest PR I've ever made, but it will prevent a lot of people from being confused why they can't push to the dataLayer... ## Related Issues issue i filed for this: gatsbyjs/gatsby#12921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request provides a plugin option that will make data in a renamed dataLayer accessible (see #12782 for details). The value assigned to "dataLayerName" is simply the renamed dataLayer (e.g. "bzDataLayer"). Then, any data pushed to a renamed dataLayer (e.g. "bzDataLayer") will also be pushed to dataLayer, thereby making it accessible through a standard GTM configuration.
Related Issues
Addresses #12782