Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-telemetry): Ensure all new installs will see the telemetry message at least once #12867

Merged
merged 1 commit into from Mar 26, 2019

Conversation

jamo
Copy link
Contributor

@jamo jamo commented Mar 26, 2019

It appears that yarn is omitting the postinstall messages.

This way the cli will also always print the message once:
https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-telemetry/src/telemetry.js#L110
@DSchau DSchau changed the title (gatsby-telemetry) Ensure all new installs will see the telemetry message at least once fix(gatsby-telemetry): Ensure all new installs will see the telemetry message at least once Mar 26, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jamo

@wardpeet wardpeet merged commit ddde1ee into master Mar 26, 2019
@wardpeet wardpeet deleted the fix-post-install-for-telemetry branch March 26, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants