feat(gatsby-plugin-less): allow passing less plugins #12898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we can't declare less loader plugins because plugins can be nested one inside each others, according to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/bootstrap/load-plugins/load.js#L134 So forwarding the "lessPlugins" attribute to the plugins loader option is a workaround to avoid this problem. See original issue #4645 But I think Gatsby should rather generalize find a more robust and generalized solution to this conflict between "gatsby plugins with gatsby subplugins" vs "gatsby plugin with plugin taking plugins as params"
slorber
changed the title
slorber
commented
Mar 27, 2019
pieh
requested changes
Apr 15, 2019
|
I'll fix unit tests after README changes - they only break because there is empty array by default, which is not present in snapshots |
|
I'll do the changes next Monday when I come back from holiday. Thanks for
the review
Le lun. 15 avr. 2019 à 19:08, Michal Piechowiak <notifications@github.com>
a écrit :
… I'll fix unit tests after README changes - they only break because there
is empty array by default, which is not present in snapshots
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#12898 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtvPldmVqTEmsFWczhpbXXr-aHXqQ-Bks5vhLIdgaJpZM4cOUPw>
.
|
|
@pieh I've added the documentation in readme |
|
@pieh don't forget me please this is a tiny change ;) |
|
Hey, it's not forgotten. I'm out of the office this week. Let's get back to
it next week.
…On Fri, May 10, 2019, 13:44 Sébastien Lorber ***@***.***> wrote:
@pieh <https://github.com/pieh> don't forget me please this is a tiny
change ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12898 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADGP3PRXRREEOOB6W5ZTLLPUWYABANCNFSM4HBZIPYA>
.
|
pieh
changed the title
pieh
approved these changes
May 13, 2019
|
Thanks for PR (and reminder) @slorber! |
|
thanks too ;) |
|
published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can't declare less loader plugins because plugins can be nested one inside each others, according to https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/src/bootstrap/load-plugins/load.js#L134
So forwarding the "lessPlugins" attribute to the plugins loader option is a workaround to avoid this problem.
See original issue #4645
But I think Gatsby should rather generalize find a more robust and generalized solution to this conflict between "gatsby plugins with gatsby subplugins" vs "gatsby plugin with plugin taking plugins as params"