Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more information to documentation pages. #1428

Merged
merged 3 commits into from Jul 9, 2017
Merged

Adds more information to documentation pages. #1428

merged 3 commits into from Jul 9, 2017

Conversation

Vagr9K
Copy link
Contributor

@Vagr9K Vagr9K commented Jul 8, 2017

Including:

  • Finishes the docpage for pathPrefix
  • Adds a note about navigateTo

@KyleAMathews
Copy link
Contributor

KyleAMathews commented Jul 8, 2017

Deploy preview ready!

Built with commit ac15d9b

https://deploy-preview-1428--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 8, 2017

Deploy preview ready!

Built with commit ac15d9b

https://deploy-preview-1428--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Jul 8, 2017

Deploy preview ready!

Built with commit ac15d9b

https://deploy-preview-1428--gatsbyjs.netlify.com

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanups!

@@ -38,3 +39,17 @@ render () {
</div>
}
```

## Forcing internal redirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The normal term for this is "Programmatic Navigation" — please change this header to that

e.g. https://stackoverflow.com/questions/31079081/programmatically-navigate-using-react-router

gatsby build --prefix-paths
```

NOTE: When using only `build`, Gatsby ignores `pathPrefix`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps re-word this to:

"NOTE: When running the command without the --prefix-paths flag, Gatsby ignores your pathPrefix."

@KyleAMathews KyleAMathews merged commit 0ac5342 into gatsbyjs:master Jul 9, 2017
@KyleAMathews
Copy link
Contributor

Just pushed the changes myself :-)

import { navigateTo } from "gatsby-link"

render () {
<div onClick={navigateTo('/example')}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, this code won't run actually though right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it had to be something like this.
I'll submit a small PR for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was referenced Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants