New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use program directory over cwd #1478
Conversation
Deploy preview ready! Built with commit a2881df |
Deploy preview failed. Built with commit a2881df https://app.netlify.com/sites/gatsbygram/deploys/5965b36b8ebdd913649a6c69 |
Deploy preview ready! Built with commit a2881df |
Thanks! |
@@ -88,7 +88,7 @@ async function startServer(program) { | |||
app.use((req, res, next) => { | |||
const parsedPath = parsePath(req.originalUrl) | |||
if (parsedPath.extname === `` || parsedPath.extname === `.html`) { | |||
res.sendFile(`${process.cwd()}/public/index.html`, err => { | |||
res.sendFile(`${program.directory()}/public/index.html`, err => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be incorrect as program.directory is not a function. gatsby-dev-cli is breaking for me because of this. I'll fix in a PR shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yea, that's my bad! Thanks for PR'ing the fix 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that some of the CI deploys worked? Looks like we have may have false positives.
This PR had a small typo #1478
No description provided.