Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): minor refactor of console functions #14956

Merged
merged 2 commits into from
Jun 21, 2019
Merged

fix(gatsby): minor refactor of console functions #14956

merged 2 commits into from
Jun 21, 2019

Conversation

leonlafa
Copy link

Description

To discourage the use of console.log in our plugins so everything that is called directly on console functions ends up being a regular log.

Related Issues

fixes issue #14834

see the issue for details on the functions changed

fixes issue #14834
@leonlafa leonlafa requested a review from a team as a code owner June 20, 2019 11:05
@leonlafa
Copy link
Author

Could someone review the changes?
Once done I'll go ahead and clean up all of the instances of console.log usage with reporter.log()

@DSchau DSchau added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Jun 21, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure of the original reason for this PR -- so tagging in @sidharthachatterjee to provide some context. Thanks!

packages/gatsby-remark-graphviz/__tests__/index.js Outdated Show resolved Hide resolved
remove file to satisify code review request
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!, this is great thanks!

@wardpeet wardpeet changed the title fix: minor refactor of console functions fix(gatsby): minor refactor of console functions Jun 21, 2019
@wardpeet wardpeet merged commit 7775b3e into gatsbyjs:master Jun 21, 2019
@gatsbot
Copy link

gatsbot bot commented Jun 21, 2019

Holy buckets, @leonlafa — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@leonlafa
Copy link
Author

@wardpeet My next task is to go through and change all the console function instances and refactor for reporter.log functions as suggested by @sidharthachatterjee

What's the best practice?

Should I raise a new issue myself or should I let one of the members raise it and then I'll start work on it?

@leonlafa leonlafa deleted the topics/reporter-logs branch June 21, 2019 15:37
@sidharthachatterjee
Copy link
Contributor

Thanks for the ping @DSchau and thank you for reviewing @wardpeet 🙌

@leonlafa Feel free to open an issue and start working on it! Thank you 💜 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants