Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-utils): create new package gatsby-core-utils #15451

Merged
merged 3 commits into from
Jul 8, 2019
Merged

feat(gatsby-utils): create new package gatsby-core-utils #15451

merged 3 commits into from
Jul 8, 2019

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Jul 5, 2019 •
edited
Loading

Description

Create new package gatsby-core-utils.

This utils package holds 3 utilities so far:

  • cpuCoreCount
  • createContentDigest
  • joinPath

Related Issues

#15433

@wardpeet wardpeet requested a review from a team as a code owner July 5, 2019 20:21
wardpeet
wardpeet commented Jul 5, 2019
View reviewed changes
Copy link
Contributor Author

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes needed ^^

packages/gatsby-utils/index.d.ts Outdated Show resolved Hide resolved
packages/gatsby-utils/src/cpu-core-count.js Outdated Show resolved Hide resolved
@wardpeet wardpeet mentioned this pull request Jul 5, 2019
Merged
@wardpeet wardpeet changed the title feat(gatsby-utils): create new package @gatsbyjs/utils feat(gatsby-utils): create new package gatsby-core-utils Jul 5, 2019
pieh
pieh approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🙏

@wardpeet wardpeet merged commit 0c890a6 into gatsbyjs:master Jul 8, 2019
@wardpeet wardpeet deleted the feat/gatsby-utils branch July 8, 2019 06:49
@wardpeet wardpeet mentioned this pull request Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wardpeet @pieh