Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): Bumps eslint-config-react-app 4.x #16168

Merged
merged 10 commits into from
Aug 21, 2019
Merged

feat(gatsby): Bumps eslint-config-react-app 4.x #16168

merged 10 commits into from
Aug 21, 2019

Conversation

ThewBear
Copy link
Contributor

@ThewBear ThewBear commented Jul 28, 2019

Description

This PR introduces eslint-config-react-app 4.0.1 which comes with

  • Typescript linting supports
  • eslint-config-react-hooks

Related Issues & PRs

#15114
#15976

@ThewBear ThewBear requested a review from a team as a code owner July 28, 2019 11:30
@ThewBear ThewBear changed the title feat(gatsby): Bumps eslint-config-react-app feat(gatsby): Bumps eslint-config-react-app 4.x Jul 28, 2019
@wardpeet
Copy link
Contributor

wardpeet commented Jul 29, 2019

Could we bump eslint-config-react-app and don't include the typescript changes yet. We can get the update in and create another PR to add Typescript support. This way we can test the typescript support separately from the upgrade.

@LekoArts you seem to have experience with TS and gatsby so hopefully, you can have a look at the PR when @thebear44 splits it.

@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Jul 29, 2019
@ThewBear
Copy link
Contributor Author

@wardpeet I removed the .tsx linting.
However, eslint-config-react-hooks lists @typescript-eslint/eslint-plugin and @typescript-eslint/parser as peer dependencies, removing them will cause npm warnings.

@m-allanson m-allanson removed the status: awaiting author response Additional information has been requested from the author label Aug 16, 2019
@wardpeet wardpeet self-assigned this Aug 21, 2019
wardpeet
wardpeet previously approved these changes Aug 21, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this one in. I've tested it on a few starters and testing .org as we speak.

@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 21, 2019
wardpeet
wardpeet previously approved these changes Aug 21, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gatsbybot gatsbybot merged commit 1bbce27 into gatsbyjs:master Aug 21, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 21, 2019

Holy buckets, @ThewBear — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants