Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Check if page exists before trying to get page data #16220

Merged
merged 3 commits into from Aug 1, 2019
Merged

fix(gatsby): Check if page exists before trying to get page data #16220

merged 3 commits into from Aug 1, 2019

Conversation

sidharthachatterjee
Copy link
Contributor

Fixes #15724

@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner July 30, 2019 13:58
pieh
pieh previously approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sidharthachatterjee
Copy link
Contributor Author

Interesting that this broke a couple of end to end tests. Will fix!

@wardpeet wardpeet mentioned this pull request Aug 1, 2019
Closed
@wardpeet wardpeet merged commit 065a551 into master Aug 1, 2019
@wardpeet wardpeet deleted the fix/unknown-page-log branch August 1, 2019 10:00
@wardpeet wardpeet mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipis lipis lipis approved these changes

@wardpeet wardpeet wardpeet approved these changes

@pieh pieh pieh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error loading a result for the page query in "/404.html". Query was not run and Page not found /404.html
4 participants
@sidharthachatterjee @lipis @pieh @wardpeet