Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Reserve graphqljs internal directive names #16483

Merged
merged 1 commit into from Aug 9, 2019
Merged

fix(gatsby): Reserve graphqljs internal directive names #16483

merged 1 commit into from Aug 9, 2019

Conversation

stefanprobst
Copy link
Contributor

Include the graphql-js directives (deprecated, include, skip) in our reserved directive names.

@stefanprobst stefanprobst requested a review from a team as a code owner August 9, 2019 08:23
sidharthachatterjee
sidharthachatterjee approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sidharthachatterjee sidharthachatterjee changed the title fix: Reserve graphqljs internal directive names fix(gatsby): Reserve graphqljs internal directive names Aug 9, 2019
@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 9, 2019
@gatsbybot gatsbybot merged commit 4032012 into gatsbyjs:master Aug 9, 2019
@stefanprobst stefanprobst deleted the reserve-directive-names branch August 9, 2019 09:20
This was referenced Apr 7, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stefanprobst @sidharthachatterjee @gatsbybot