Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(case-study): Change Incorporated Case Study #16552

Merged
merged 6 commits into from
Aug 21, 2019
Merged

docs(case-study): Change Incorporated Case Study #16552

merged 6 commits into from
Aug 21, 2019

Conversation

trys
Copy link
Contributor

@trys trys commented Aug 12, 2019

Description

A case study for the Change Incorporated website, originally posted on Clearleft.com

@trys trys requested a review from a team as a code owner August 12, 2019 14:11
@amberleyromo amberleyromo self-assigned this Aug 12, 2019
amberleyromo
amberleyromo reviewed Aug 15, 2019
View reviewed changes
Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a couple thoughts! Tagging in @caitlinthefirst for an eye on this as well. Thank you!

docs/blog/2019-08-13-creating-a-purpose-driven-media-platform/index.md Outdated Show resolved Hide resolved
docs/blog/2019-08-13-creating-a-purpose-driven-media-platform/index.md Outdated Show resolved Hide resolved
docs/blog/2019-08-13-creating-a-purpose-driven-media-platform/index.md Outdated Show resolved Hide resolved
docs/blog/2019-08-13-creating-a-purpose-driven-media-platform/index.md Outdated Show resolved Hide resolved
docs/blog/2019-08-13-creating-a-purpose-driven-media-platform/index.md Outdated Show resolved Hide resolved
docs/blog/2019-08-13-creating-a-purpose-driven-media-platform/index.md Outdated Show resolved Hide resolved
docs/blog/2019-08-13-creating-a-purpose-driven-media-platform/index.md Outdated Show resolved Hide resolved
@trys
Copy link
Contributor Author

trys commented Aug 19, 2019

@amberleyromo Wonderful - thanks for the comments! I've pushed the changes 😄

caitlinthefirst
caitlinthefirst previously requested changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@caitlinthefirst caitlinthefirst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the double-comment. Let's avoid calling Gatsby a static site generator. How about "...and the React-based web framework, Gatsby..."?

@caitlinthefirst
Revise description of Gatsby
b6ef79d 
Made change I had requested.
sidharthachatterjee
sidharthachatterjee approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 21, 2019
@sidharthachatterjee sidharthachatterjee merged commit e78bce3 into gatsbyjs:master Aug 21, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 21, 2019

Holy buckets, @trys — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

DSchau pushed a commit that referenced this pull request Aug 21, 2019
docs(case-study): Change Incorporated Case Study (#16552)
e640e82
sidharthachatterjee added a commit that referenced this pull request Aug 21, 2019
@sidharthachatterjee
Revert "docs(case-study): Change Incorporated Case Study (#16552)"
60b9535 
This reverts commit e640e82.
DSchau pushed a commit that referenced this pull request Aug 21, 2019
Revert "docs(case-study): Change Incorporated Case Study (#16552)"
4b9e069 
This reverts commit e640e82.
sidharthachatterjee added a commit that referenced this pull request Aug 21, 2019
@sidharthachatterjee
Revert "Revert "docs(case-study): Change Incorporated Case Study (#16552
c2fc3ee 
)""

This reverts commit 4b9e069.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amberleyromo amberleyromo amberleyromo left review comments

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

@caitlinthefirst caitlinthefirst caitlinthefirst left review comments

Assignees

@caitlinthefirst caitlinthefirst

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@trys @amberleyromo @sidharthachatterjee @caitlinthefirst @lannonbr @m-allanson