Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(load-plugins): fix snapshot #17515

Closed
wants to merge 1 commit into from
Closed

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 9, 2019

there were recently 2 separate PRs that updated this snapshot:

and seems like one that was merged last wasn't rebased on master which caused snapshot to desync and now it fails consistently (i.e. https://circleci.com/gh/gatsbyjs/gatsby/219854?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link )

I'm not exactly sure if this just hides the issue or not so need some eyes on this to verify

/cc @universse @akshayymahajan

@pieh pieh requested a review from a team as a code owner September 9, 2019 17:45
@pieh pieh changed the title test: fix snapshot test(load-plugins): fix snapshot Sep 9, 2019
@kimbaudi
Copy link
Contributor

kimbaudi commented Sep 9, 2019

I also see this snapshot test failing (#17154 (comment))

@sidharthachatterjee
Copy link
Contributor

Eh, I fixed and then found this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants