Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-theme-notes): replace path.join #17648

Merged
merged 1 commit into from Sep 16, 2019
Merged

fix(gatsby-theme-notes): replace path.join #17648

merged 1 commit into from Sep 16, 2019

Conversation

divslinger
Copy link
Contributor

Fixes #17647

Same fix as #15370

@divslinger divslinger requested a review from a team as a code owner September 15, 2019 19:51
@divslinger divslinger added topic: themes type: bug An issue or pull request relating to a bug in Gatsby labels Sep 15, 2019
wardpeet
wardpeet approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for fixing!

@wardpeet wardpeet merged commit 362bba2 into master Sep 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the divslinger-patch-1 branch September 16, 2019 10:22
LOLdevelopr pushed a commit to LOLdevelopr/gatsby-1 that referenced this pull request Sep 21, 2019
@LOLdevelopr
fix(gatsby-theme-notes): replace path.join with urlResolve (gatsbyjs#…
6d11860 
…17648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-theme-notes directory list doesn't work on Windows
2 participants
@divslinger @wardpeet