Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error-overlay from CRA #1835

Closed
wants to merge 3 commits into from
Closed

Conversation

nickmaltsev
Copy link
Contributor

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 16, 2017

Deploy preview ready!

Built with commit d47956d

https://deploy-preview-1835--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 16, 2017

Deploy preview ready!

Built with commit d47956d

https://deploy-preview-1835--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit d47956d

https://app.netlify.com/sites/using-glamor/deploys/599579cb424ef208680a7e4a

@KyleAMathews
Copy link
Contributor

Hey @nickmaltsev thanks for looking into this! Your change though doesn't seem to have changed anything… check out the screenshot below I pulled from the CRA README. The error is styled differently than the one in your GIF.

@nickmaltsev
Copy link
Contributor Author

@KyleAMathews i just used react-error-overlay the same way as it used in CRA. Screenshot that you linked above probably just outdated. Sorry if i miss something again ;)

@KyleAMathews
Copy link
Contributor

No—webpack has a default error overlay which is why it looks like it's working.

Here's a screenshot I just took with the default starter.

screen shot 2017-08-19 at 9 06 23 am

It might be that CRA's overlay only works on webpack 2+. Did you investigate that?

@nickmaltsev
Copy link
Contributor Author

@KyleAMathews oh.. my bad :) will investigate

@KyleAMathews
Copy link
Contributor

This looks like the latest state of using the overlay elsewhere facebook/create-react-app#2515 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants