Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/fix sourcing from prismic #18402

Closed
wants to merge 10 commits into from
Closed

Docs/fix sourcing from prismic #18402

wants to merge 10 commits into from

Conversation

jonniebigodes
Copy link

Description

While triaging and trying to help a person with a issue related with gatsby and prismic, I followed the existing documentation for sourcing from prismic located here reading up on it it came to my attention that is leading people into installing dotenv, but upon testing and checking the changes made to gatsby recently, the package is already present and it doesn't need to be added as extra dependency to the site.

With that i changed the wording in the documentation to reflect the change and removed code snippet for relevant to the dotenv package installation.

Related Issues

jonniebigodes added 10 commits January 4, 2019 02:11
@jonniebigodes jonniebigodes requested a review from a team as a code owner October 9, 2019 18:54
@LekoArts
Copy link
Contributor

Hi, thanks for opening the PR!
It doesn't hurt to tell people to install dotenv as it makes things more explicit (one might ask if dotenv would only be available in this starter?). We also do that in other guides through out the docs.

Thanks for the work you've done so far on issues/PRs, really appreciate it!

@LekoArts LekoArts closed this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants